jparkzz commented on code in PR #1937:
URL: https://github.com/apache/polaris/pull/1937#discussion_r2176039446
##########
helm/polaris/templates/configmap.yaml:
##########
@@ -53,6 +53,11 @@ data:
{{- $_ = set $map "polaris.persistence.eclipselink.persistence-unit"
.Values.persistence.eclipseLink.persistenceUnit -}}
{{- $_ = set $map "polaris.persistence.eclipselink.configuration-file"
(printf "%s/persistence.xml" .Values.image.configDir ) -}}
{{- end -}}
+ {{- if eq .Values.persistence.type "relational-jdbc" -}}
+ {{- if .Values.persistence.relationalJdbc.dbKind -}}
+ {{- $_ = set $map "quarkus.datasource.db-kind"
.Values.persistence.relationalJdbc.dbKind -}}
Review Comment:
Would you prefer to configure dbKind within the secret? With current chart,
even if we set it in the secret, I believe the value would still be explicitly
visible in the helm chart when it's injected as an environment variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
