flyrain commented on code in PR #1932:
URL: https://github.com/apache/polaris/pull/1932#discussion_r2176149139
##########
polaris-core/src/test/java/org/apache/polaris/service/storage/aws/AwsCredentialsStorageIntegrationTest.java:
##########
@@ -79,7 +80,7 @@ public void testGetSubscopedCreds() {
.returns(roleARN, AssumeRoleRequest::roleArn);
return ASSUME_ROLE_RESPONSE;
});
- String warehouseDir = "s3://bucket/path/to/warehouse";
+ String warehouseDir = scheme + "://bucket/path/to/warehouse";
Review Comment:
LGTM, thanks for adding these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
