flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2178824185
##########
plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/SparkCatalogIcebergIT.java:
##########
@@ -19,33 +19,19 @@
package org.apache.polaris.spark.quarkus.it;
import io.quarkus.test.junit.QuarkusIntegrationTest;
+import org.apache.polaris.service.it.ext.SparkSessionBuilder;
import org.apache.spark.sql.SparkSession;
@QuarkusIntegrationTest
public class SparkCatalogIcebergIT extends SparkCatalogBaseIT {
/** Initialize the spark catalog to use the iceberg spark catalog. */
@Override
- protected SparkSession.Builder withCatalog(SparkSession.Builder builder,
String catalogName) {
- return builder
- .config(
- "spark.sql.extensions",
-
"org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions")
- .config(
- String.format("spark.sql.catalog.%s", catalogName),
- "org.apache.iceberg.spark.SparkCatalog")
- .config("spark.sql.warehouse.dir", warehouseDir.toString())
- .config(String.format("spark.sql.catalog.%s.type", catalogName),
"rest")
- .config(
- String.format("spark.sql.catalog.%s.uri", catalogName),
- endpoints.catalogApiEndpoint().toString())
- .config(String.format("spark.sql.catalog.%s.warehouse", catalogName),
catalogName)
- .config(String.format("spark.sql.catalog.%s.scope", catalogName),
"PRINCIPAL_ROLE:ALL")
- .config(
- String.format("spark.sql.catalog.%s.header.realm", catalogName),
endpoints.realmId())
- .config(String.format("spark.sql.catalog.%s.token", catalogName),
sparkToken)
- .config(String.format("spark.sql.catalog.%s.s3.access-key-id",
catalogName), "fakekey")
- .config(
- String.format("spark.sql.catalog.%s.s3.secret-access-key",
catalogName), "fakesecret")
- .config(String.format("spark.sql.catalog.%s.s3.region", catalogName),
"us-west-2");
+ protected SparkSession buildSparkSession() {
+ return SparkSessionBuilder.withTestDefaults()
+ .withS3MockContainer()
+ .withExtensions(SparkSessionBuilder.ExtensionType.ICEBERG_ONLY)
Review Comment:
https://github.com/apache/polaris/pull/1985/files#r2178823978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
