eric-maynard commented on code in PR #1990:
URL: https://github.com/apache/polaris/pull/1990#discussion_r2180488238
##########
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -981,7 +983,7 @@ public PrincipalWithCredentials
createPrincipal(PolarisEntity entity) {
entity.getName());
}
return new PrincipalWithCredentials(
- new PrincipalEntity(principalResult.getPrincipal()).asPrincipal(),
+ toPrincipal(new PrincipalEntity(principalResult.getPrincipal())),
Review Comment:
Not a big fan of the static imports outside of test code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
