dimas-b commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180644252


##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration<T> {
 
   public final String key;
   public final String description;
+  public final Set<String> legacyKeys;

Review Comment:
   Is this value used for property config value lookup? Sorry, if I missed it 
in the diff :thinking: 



##########
CHANGELOG.md:
##########
@@ -38,6 +38,7 @@ request adding CHANGELOG notes for breaking (!) changes and 
possibly other secti
 ### Changes
 
 ### Deprecations
+- Deprecates the `SUPPORTED_CATALOG_CONNECTION_TYPES` and replaces it with 
`SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES`. 

Review Comment:
   ```suggestion
   - Deprecates the `SUPPORTED_CATALOG_CONNECTION_TYPES` configuration property 
and replaces it with `SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES`. 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to