MonkeyCanCode commented on PR #1995: URL: https://github.com/apache/polaris/pull/1995#issuecomment-3046736188
> @MonkeyCanCode Thanks for improving the Makefile! Overall LGTM > > There are some discussion around doing the code check/format in a different way: #1986. Since the current one is an improvement of the existing solution, I suggest we seek to merge this first and change later based on the result of #1986 Exactly, it is a lot harder to do without this piece first (thinking about using native shell and markfile route instead of a third party plugin which may not be supported after 1-2 years). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
