HonahX commented on PR #1986: URL: https://github.com/apache/polaris/pull/1986#issuecomment-3046758373
Thanks @eric-maynard and @MonkeyCanCode for the thorough explanations! I think the idea of adding convenient task in gradle is great. The questions lie more on the practical side that we seems do not have well-maintained/well functioned plugin to do so. Apart from the support problem of the current plugin, I am also a little bit concerned that this `use-python` plugin will use a virtual env (`.gradle/python`) other than one managed by poetry to run the code format/check. This means we are maintaining 2 dev python env in the codebase and may cause behavior deviation/confusion at some point. Is it possible to make gradle task execute purely command line? Ideally the gradle task could be calling the Makefile target we define here https://github.com/apache/polaris/pull/1995. In this way, we keep the MakeFile approach and also have convenient gradle tasks. Developers can choose whatever approaches they want and yet we only have a single dev environment and all deps are managed by poetry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
