singhpk234 commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2195181073
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -94,7 +101,7 @@ public AwsStorageConfigurationInfo(
@Nonnull String roleARN,
@Nullable String externalId,
@Nullable String region) {
- this(storageType, allowedLocations, roleARN, externalId, region, null,
null);
+ this(storageType, allowedLocations, roleARN, externalId, region, null,
null, false);
Review Comment:
when we have `PATH_STYLE_ACCESS_DEFAULT` defined we can wire in that or just
null here so that actual default get applied with Optional handling L87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
