dimas-b commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2207515413
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
My point is two-fold:
1) we add a new property - this can potentially break old clients if they
are sensitive to the presence of unknown properties (unlikely but possible)
2) the way this PR is implemented does not expose new properties in JSON
responses if they are not explicitly configured - this ensures backward
compatibility with in existing servers. (I also mentioned that in the dev
email).
If a user decided to configure the new properties, the user has to assume
responsibility for possible client-side breakage (which, again, in unlikely).
Does this sound acceptable to you? (note: Robert did not -1 this PR :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
