MonkeyCanCode commented on code in PR #2051: URL: https://github.com/apache/polaris/pull/2051#discussion_r2209104420
########## site/bin/_hugo-docker-include.sh: ########## @@ -17,8 +17,10 @@ # under the License. # -DOCKER="$(which podman > /dev/null && echo podman || echo docker)" -COMPOSE="$(which podman-compose > /dev/null && echo podman-compose || echo docker-compose)" +[[ -f site/.user-settings ]] && . site/.user-settings + +[[ -z ${DOCKER} ]] && DOCKER="$(which podman > /dev/null && echo podman || echo docker)" Review Comment: nit: maybe use more compact version such as following: ``` DOCKER="${DOCKER:-$(which podman >/dev/null && echo podman || echo docker)}" COMPOSE="${COMPOSE:-$(which podman-compose >/dev/null && echo podman-compose || echo docker-compose)}" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org