dimas-b commented on code in PR #2048:
URL: https://github.com/apache/polaris/pull/2048#discussion_r2212265178
##########
polaris-core/src/main/java/org/apache/polaris/core/policy/PredefinedPolicyTypes.java:
##########
@@ -28,7 +28,8 @@ public enum PredefinedPolicyTypes implements PolicyType {
DATA_COMPACTION(0, "system.data-compaction", true),
METADATA_COMPACTION(1, "system.metadata-compaction", true),
ORPHAN_FILE_REMOVAL(2, "system.orphan-file-removal", true),
- SNAPSHOT_EXPIRY(3, "system.snapshot-expiry", true);
+ SNAPSHOT_EXPIRY(3, "system.snapshot-expiry", true),
+ ACCESS_CONTROL(4, "system.access-control", false);
Review Comment:
I do not have a firm opinion on the specific form of these policies (yet).
However, I'd like to make this system extensible. That is, if we have
another kind of policy for row filtering, assigning the generic
`ACCESS_CONTROL` name to the current one will make the new policy kind of
marginal. This is why I propose for policy type names to be more specific up
front.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
