MonkeyCanCode commented on code in PR #2145:
URL: https://github.com/apache/polaris/pull/2145#discussion_r2220812337
##########
client/python/cli/command/catalog_roles.py:
##########
@@ -76,7 +76,7 @@ def execute(self, api: PolarisDefaultApi) -> None:
elif self.catalog_roles_subcommand == Subcommands.DELETE:
api.delete_catalog_role(self.catalog_name, self.catalog_role_name)
elif self.catalog_roles_subcommand == Subcommands.GET:
- print(
+ self.logger.info(
Review Comment:
> I'm not sure it's appropriate to characterize this as _logging_ -- this is
a CLI, so stdout is really the output of the program
Okay, let me put this back to draft and implement with debug flag without
it. Thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
