snazy commented on code in PR #2148:
URL: https://github.com/apache/polaris/pull/2148#discussion_r2221299358
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisEntityManager.java:
##########
@@ -40,39 +39,28 @@
*/
public class PolarisEntityManager {
private final PolarisMetaStoreManager metaStoreManager;
- private final EntityCache entityCache;
+ private final ResolverFactory resolverFactory;
// Lazily instantiated only a single time per entity manager.
private ResolvedPolarisEntity implicitResolvedRootContainerEntity = null;
/**
* @param metaStoreManager the metastore manager for the current realm
- * @param entityCache the entity cache to use (it may be {@code null}).
+ * @param resolverFactory the resolver factor to use
*/
public PolarisEntityManager(
- @Nonnull PolarisMetaStoreManager metaStoreManager, @Nullable EntityCache
entityCache) {
+ @Nonnull PolarisMetaStoreManager metaStoreManager, @Nonnull
ResolverFactory resolverFactory) {
Review Comment:
Nit:
```suggestion
@Nonnull PolarisMetaStoreManager metaStoreManager, ResolverFactory
resolverFactory) {
```
We kind-of agreed that parameters a not-null by default. But I don't mind
having it explicit.
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisEntityManager.java:
##########
@@ -40,39 +39,28 @@
*/
public class PolarisEntityManager {
private final PolarisMetaStoreManager metaStoreManager;
- private final EntityCache entityCache;
+ private final ResolverFactory resolverFactory;
// Lazily instantiated only a single time per entity manager.
private ResolvedPolarisEntity implicitResolvedRootContainerEntity = null;
/**
* @param metaStoreManager the metastore manager for the current realm
- * @param entityCache the entity cache to use (it may be {@code null}).
+ * @param resolverFactory the resolver factor to use
Review Comment:
```suggestion
* @param resolverFactory the resolver factory to use
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
