rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180781727
##########
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java:
##########
@@ -68,7 +68,7 @@ public Table loadTable(Identifier identifier) throws
NoSuchTableException {
try {
GenericTable genericTable =
this.polarisCatalog.loadGenericTable(Spark3Util.identifierToTableIdentifier(identifier));
- return PolarisCatalogUtils.loadSparkTable(genericTable);
+ return PolarisCatalogUtils.loadSparkTable(genericTable, identifier);
Review Comment:
Currently PolarisCatalogUtils itself is not leveraging any interface, its
just a util method
https://github.com/apache/polaris/blob/main/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java#L69
thats used to provide back an impl of Spark's `Table` interface. So there are
no interfaces changes just an additional param passed in this method.
I needed to do this for hudi as it will need a full identifier to the table
in order to create construct Spark's V1 Catalog Table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
