sclee01 commented on code in PR #2196:
URL: https://github.com/apache/polaris/pull/2196#discussion_r2238603373
##########
runtime/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -43,6 +44,12 @@ public MetaStoreManagerFactory metaStoreManagerFactory(
return
metaStoreManagerFactories.select(Identifier.Literal.of(persistenceType)).get();
}
+ @Produces
+ @ApplicationScoped
+ public SchemaInitializer schemaInitializer(MetaStoreManagerFactory
metaStoreManagerFactory) {
+ return (SchemaInitializer) metaStoreManagerFactory;
Review Comment:
I didn't use `.select()` because only `JdbcMetaStoreManagerFactory`
implements that interface.
If I use `.select()`, it could cause errors at runtime when using other
`MetaStoreManagerFactory` implementations that don't implement
`SchemaInitializer`. Given that, I kept the cast with a type check to avoid
breaking compatibility. Open to suggestions if there's a safer way to handle
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
