aacampbell commented on code in PR #2244:
URL: https://github.com/apache/polaris/pull/2244#discussion_r2255591447


##########
getting-started/keycloak/README.md:
##########
@@ -0,0 +1,163 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+ 
+   http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+
+# Getting Started with Apache Polaris, External Authentication and Keycloak
+
+## Overview
+
+This example uses Keycloak as the identity provider for Polaris. The "iceberg" 
realm is automatically created and
+configured from the `iceberg-realm.json` file. 
+
+This Keycloak realm contains 1 client definition: `client1:s3cr3t`, and 2 
custom scopes: `catalog` and `sign`. It is
+also configured to return tokens with the following fixed claims:

Review Comment:
   The confusion might come from the fact that when making a request to the 
internal deprecated iceberg oauth token endpoint we include `"scope": 
"PRINCIPAL_ROLE:ALL"` and it's not clear why - especially when we don't include 
it in the request to keycloak. In fact I don't think the documentation mentions 
at all how these role work, which to request, and why. I think there might even 
by a typo in the external-idp document where it sometimes says `POLARIS_ROLE:` 
instead of `PRINCIPAL_ROLE:`. A lot of behaviour requires delving into source 
code to learn.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to