sfc-gh-yzou commented on code in PR #2262:
URL: https://github.com/apache/polaris/pull/2262#discussion_r2258065313
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/EntityNameLookupRecord.java:
##########
@@ -89,14 +89,14 @@ public EntityNameLookupRecord(
this.subTypeCode = subTypeCode;
}
- /** Constructor to create the object with provided entity */
- public EntityNameLookupRecord(PolarisBaseEntity entity) {
- this.catalogId = entity.getCatalogId();
- this.id = entity.getId();
- this.parentId = entity.getParentId();
- this.typeCode = entity.getTypeCode();
- this.name = entity.getName();
- this.subTypeCode = entity.getSubTypeCode();
+ public static EntityNameLookupRecord fromEntity(PolarisBaseEntity entity) {
Review Comment:
what is the motivation for this change here? if no particular reason, can we
keep the original constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
