eric-maynard commented on code in PR #2149:
URL: https://github.com/apache/polaris/pull/2149#discussion_r2261186690
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageUtil.java:
##########
@@ -62,4 +68,50 @@ public class StorageUtil {
public static @Nonnull String getBucket(URI uri) {
return uri.getAuthority();
}
+
+ /** Given a TableMetadata, extracts the locations where the table's
[meta]data might be found. */
+ public static @Nonnull Set<String>
getLocationsAllowedToBeAccessed(TableMetadata tableMetadata) {
+ return getLocationsAllowedToBeAccessed(tableMetadata.location(),
tableMetadata.properties());
+ }
+
+ /** Given a baseLocation and entity (table?) properties, extracts the
relevant locations */
+ public static @Nonnull Set<String> getLocationsAllowedToBeAccessed(
+ String baseLocation, Map<String, String> properties) {
+ Set<String> locations = new HashSet<>();
+ locations.add(baseLocation);
+ if
(properties.containsKey(IcebergTableLikeEntity.USER_SPECIFIED_WRITE_DATA_LOCATION_KEY))
{
+
locations.add(properties.get(IcebergTableLikeEntity.USER_SPECIFIED_WRITE_DATA_LOCATION_KEY));
+ }
+ if
(properties.containsKey(IcebergTableLikeEntity.USER_SPECIFIED_WRITE_METADATA_LOCATION_KEY))
{
+ locations.add(
+
properties.get(IcebergTableLikeEntity.USER_SPECIFIED_WRITE_METADATA_LOCATION_KEY));
+ }
+ return removeRedundantLocations(locations);
+ }
+
+ /** Given a ViewMetadata, extracts the locations where the view's [meta]data
might be found. */
+ public static @Nonnull Set<String>
getLocationsAllowedToBeAccessed(ViewMetadata viewMetadata) {
+ return Set.of(viewMetadata.location());
+ }
+
+ /** Removes "redundant" locations, so {/a/b/, /a/b/c, /a/b/d} will be
reduced to just {/a/b/} */
+ private static @Nonnull Set<String> removeRedundantLocations(Set<String>
locationStrings) {
+ HashSet<String> result = new HashSet<>(locationStrings);
Review Comment:
The main change to the javadocs seems to be comments like `Must be
overridden by subclasses`, but I don't think that's true. In fact it's the
opposite -- to date we've only created subclasses where we wish to override,
but we could create subclasses where it's not necessary. For example, a
`LocalStorageLocation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
