snazy commented on code in PR #2396: URL: https://github.com/apache/polaris/pull/2396#discussion_r2287275934
########## site/content/in-dev/unreleased/getting-started/install-dependencies.md: ########## @@ -44,19 +44,39 @@ Then, use git to clone the Polaris repo: git clone https://github.com/apache/polaris.git ~/polaris ``` -## Docker - -It is recommended to deploy Polaris inside [Docker](https://www.docker.com/) for the Quickstart workflow. Instructions for deploying the Quickstart workflow on the supported Cloud Providers (AWS, Azure, GCP) will be provided only with Docker. However, non-Docker deployment instructions for local deployments can also be followed on Cloud Providers. +## Docker Container Runtime & Docker Compose +It is recommended to deploy Polaris inside Docker Compatible Container Runtime for the Quickstart workflow. Instructions for deploying the Quickstart workflow on the supported Cloud Providers (AWS, Azure, GCP) will be provided only with Docker. However, non-Docker deployment instructions for local deployments can also be followed on Cloud Providers. Review Comment: ```suggestion It is recommended to deploy Polaris inside a Container Runtime, for example, Podman or Docker, for the Quickstart workflow. Instructions for deploying the Quickstart workflow on the supported Cloud Providers (AWS, Azure, GCP) are provided using the docker CLI tool syntax. ``` What do you mean with ` However, non-Docker deployment instructions for local deployments can also be followed on Cloud Providers.`? ########## site/content/in-dev/unreleased/getting-started/install-dependencies.md: ########## @@ -82,7 +102,19 @@ sudo sed -i 's/$releasever/9/g' /etc/yum.repos.d/docker-ce.repo sudo dnf -y install docker-ce docker-ce-cli containerd.io docker-buildx-plugin docker-compose-plugin ``` -### Confirm Docker Installation +### Podman +Docker Desktop may not be suitable for you due to licensing restrictions (check https://docs.docker.com/subscription/desktop-license/), so you can use alternative Container Tool versions compatible with Docker, for example [podman](https://podman.io/). Review Comment: I'd move Podman before Docker, as the instructions for the latter require (commercial) users to get a paid license. ########## site/content/in-dev/unreleased/getting-started/install-dependencies.md: ########## @@ -44,19 +44,39 @@ Then, use git to clone the Polaris repo: git clone https://github.com/apache/polaris.git ~/polaris ``` -## Docker - -It is recommended to deploy Polaris inside [Docker](https://www.docker.com/) for the Quickstart workflow. Instructions for deploying the Quickstart workflow on the supported Cloud Providers (AWS, Azure, GCP) will be provided only with Docker. However, non-Docker deployment instructions for local deployments can also be followed on Cloud Providers. +## Docker Container Runtime & Docker Compose +It is recommended to deploy Polaris inside Docker Compatible Container Runtime for the Quickstart workflow. Instructions for deploying the Quickstart workflow on the supported Cloud Providers (AWS, Azure, GCP) will be provided only with Docker. However, non-Docker deployment instructions for local deployments can also be followed on Cloud Providers. +### Docker Desktop Instructions to install Docker can be found on the [Docker website](https://docs.docker.com/engine/install/). Ensure that Docker and the Docker Compose plugin are both installed. Review Comment: ```suggestion Instructions to install Docker can be found on the [Docker website](https://docs.docker.com/engine/install/). Ensure that Docker and the Docker Compose plugin are both installed. The links lead to "Docker Desktop", be mindful of the licensing terms. ``` ########## site/content/in-dev/unreleased/getting-started/quickstart.md: ########## @@ -37,9 +46,11 @@ cd ~/polaris :polaris-admin:quarkusAppPartsBuild --rerun \ -Dquarkus.container-image.build=true ``` -- **For standalone**: Omit the `-Dquarkus.container-image.tag` and `-Dquarkus.container-image.build` options if you do not need to build a Docker image. +> **For podman**: Use `-Dquarkus.docker.executable-name=podman` or `-Dquarkus.container-image.builder=podman` argument. Review Comment: Note: I've never set these options on Ubuntu, with the distro's `podman-docker` package installed. ########## site/content/in-dev/unreleased/getting-started/install-dependencies.md: ########## @@ -65,7 +85,7 @@ docker run --security-opt seccomp=unconfined apache/polaris:latest Note: Setting the seccomp profile to "unconfined" disables the default system call filtering, which may pose security risks. Use this configuration with caution, especially in production environments. -### Docker on Amazon Linux +#### Docker on Amazon Linux Review Comment: ```suggestion #### Podman on Ubuntu Ubuntu, in its recent releases, provides podman in versions suitable for both building Polaris and running containerized tests. ```bash sudo apt-get install podman podman-compose podman-docker ``` #### Docker on Amazon Linux ``` ########## site/content/in-dev/unreleased/getting-started/install-dependencies.md: ########## @@ -82,7 +102,19 @@ sudo sed -i 's/$releasever/9/g' /etc/yum.repos.d/docker-ce.repo sudo dnf -y install docker-ce docker-ce-cli containerd.io docker-buildx-plugin docker-compose-plugin ``` -### Confirm Docker Installation +### Podman +Docker Desktop may not be suitable for you due to licensing restrictions (check https://docs.docker.com/subscription/desktop-license/), so you can use alternative Container Tool versions compatible with Docker, for example [podman](https://podman.io/). Review Comment: ```suggestion Docker Desktop may not be suitable for you due to licensing restrictions (check https://docs.docker.com/subscription/desktop-license/), so you can use alternative Container Runtimes, for example, [podman](https://podman.io/). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
