HonahX opened a new pull request, #2435:
URL: https://github.com/apache/polaris/pull/2435
<!--
Possible security vulnerabilities: STOP here and contact
[email protected] instead!
Please update the title of the PR with a meaningful message - do not
leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in
this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly
hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in
site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
`PolarisAdminService.createCatalog` only checks and error out if the return
status of `CreateCatalogResult` is `ENTITY_ALREADY_EXISTS`. Although we do not
have any other error status specifically for CreateCatalog, we do have a
general `UNEXPECED_ERROR_SIGNALED` status for all other failures. Currently if
the persistence sends back an `UNEXPECED_ERROR_SIGNALED`, the
`PolarisAdminService` will proceed to return the entity field in the result
(`null`) which result in a NPE at
https://github.com/apache/polaris/blob/main/runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java#L167.
This PR updates the `PolarisAdminService.CreateCatalog` to check whether the
status is success and also use `CatalogEntity.of` which does a null check to
remove the NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
