flyrain commented on code in PR #2473:
URL: https://github.com/apache/polaris/pull/2473#discussion_r2312156581
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewIntegrationBase.java:
##########
@@ -201,16 +201,10 @@ public void
createViewWithCustomMetadataLocationUsingPolaris(@TempDir Path tempD
TableIdentifier identifier = TableIdentifier.of("ns", "view");
String location = Paths.get(tempDir.toUri().toString()).toString();
Review Comment:
It turns out the Polaris added a structured location to the view in
https://github.com/apache/polaris/pull/1966. When a rest client creates view
with location A, the Polaris will automatically adds the prefix like
/root/namespace/A, related code
https://github.com/apache/polaris/blob/17a359b43cf961a1261a7dfa7405ff47fb06b5f3/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java#L1244.
I don’t think this is correct, it breaks the contract between Iceberg REST
clients and servers. The REST Server should only modify the location when it’s
missing.
The unit tests I added don't have the issue as it doesn't go through that
route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
