adutra commented on code in PR #2479: URL: https://github.com/apache/polaris/pull/2479#discussion_r2318169836
########## runtime/service/src/main/java/org/apache/polaris/service/events/CatalogPolicyServiceEvents.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.service.events; + +import org.apache.polaris.service.types.AttachPolicyRequest; +import org.apache.polaris.service.types.CreatePolicyRequest; +import org.apache.polaris.service.types.DetachPolicyRequest; +import org.apache.polaris.service.types.GetApplicablePoliciesResponse; +import org.apache.polaris.service.types.LoadPolicyResponse; +import org.apache.polaris.service.types.UpdatePolicyRequest; + +/** + * Event records for Catalog Policy operations. Each operation has corresponding "Before" and + * "After" event records. + */ +public class CatalogPolicyServiceEvents { + + // Policy CRUD Events + public record BeforeCreatePolicyEvent( Review Comment: Sorry to insist on naming, but it's still inconsistent. In #2482 we have `(Before|After)(Object)(Verb)Event`. Here we have `(Before|After)(Verb)(Object)Event`. (I find verb-object more natural than object-verb btw, but I'll defer the decision to native English speakers.) ########## runtime/service/src/main/java/org/apache/polaris/service/catalog/policy/CatalogPolicyEventServiceDelegator.java: ########## @@ -132,14 +199,31 @@ public Response getApplicablePolicies( String policyType, RealmContext realmContext, SecurityContext securityContext) { - return delegate.getApplicablePolicies( - prefix, - pageToken, - pageSize, - namespace, - targetName, - policyType, - realmContext, - securityContext); + String catalogName = getCatalogFromPrefix(prefix, realmContext); + polarisEventListener.onBeforeGetApplicablePolicies( + new CatalogPolicyServiceEvents.BeforeGetApplicablePoliciesEvent( + catalogName, namespace, targetName, policyType)); + Response resp = + delegate.getApplicablePolicies( + prefix, + pageToken, + pageSize, + namespace, + targetName, + policyType, + realmContext, + securityContext); + polarisEventListener.onAfterGetApplicablePolicies( + new CatalogPolicyServiceEvents.AfterGetApplicablePoliciesEvent( + catalogName, + namespace, + targetName, + policyType, + (GetApplicablePoliciesResponse) resp.getEntity())); + return resp; + } + + private String getCatalogFromPrefix(String prefix, RealmContext realmContext) { Review Comment: nit: inline the method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
