HonahX commented on code in PR #2448:
URL: https://github.com/apache/polaris/pull/2448#discussion_r2320680187
##########
client/python/cli/constants.py:
##########
@@ -371,9 +371,5 @@ class Namespaces:
CLIENT_PROFILE_ENV = "CLIENT_PROFILE"
DEFAULT_HOSTNAME = "localhost"
DEFAULT_PORT = 8181
-CONFIG_DIR = os.environ.get("SCRIPT_DIR")
-if CONFIG_DIR is None:
- raise Exception(
- "The SCRIPT_DIR environment variable is not set. Please set it to the
Polaris's script directory."
- )
+CONFIG_DIR = (os.environ.get("POLARIS_HOME") or "").strip() or
os.path.expanduser("~/.polaris")
Review Comment:
Should we fall back to use SCRIPT_DIR if given for backward compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
