adnanhemani commented on code in PR #2482:
URL: https://github.com/apache/polaris/pull/2482#discussion_r2326033136
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##########
@@ -651,13 +646,13 @@ public Response addGrantToCatalogRole(
catalogName);
PolarisAdminService adminService = newAdminService(realmContext,
securityContext);
PrivilegeResult result;
+ PolarisPrivilege privilege;
switch (grantRequest.getGrant()) {
// The per-securable-type Privilege enums must be exact String match for
a subset of all
// PolarisPrivilege values.
case ViewGrant viewGrant:
{
- PolarisPrivilege privilege =
- PolarisPrivilege.valueOf(viewGrant.getPrivilege().toString());
+ privilege =
PolarisPrivilege.valueOf(viewGrant.getPrivilege().toString());
Review Comment:
Not a requirement, but is a helpful refactor that will help in the future
if/when we change the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
