dimas-b commented on code in PR #2507:
URL: https://github.com/apache/polaris/pull/2507#discussion_r2330707408
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisManagementServiceIntegrationTest.java:
##########
@@ -136,6 +136,10 @@ public void tearDown() {
client.cleanUp(authToken);
}
+ private static String newRandomString(int length) {
+ return RandomStringUtils.insecure().next(length, true, true);
Review Comment:
I can only guess what the intention behind the randomized version might have
been.
I'd start with names containing ASCII upper/lower case letters and numbers
having the the max allowed name length. I think that one case is sufficient for
now.
Replacing random name with a fixes name as noted above is not going to
reduce the tests' validity, but will improve determinism.
If we want to test other edge cases, it might be preferable to do so in a
unit test targeting the validation code (if such validation code exists).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
