dimas-b commented on code in PR #2523:
URL: https://github.com/apache/polaris/pull/2523#discussion_r2331456122
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -232,6 +233,24 @@ public ProductionReadinessCheck checkPolarisEventListener(
return ProductionReadinessCheck.OK;
}
+ @Produces
+ public ProductionReadinessCheck checkServiceIdentities(
+ ServiceIdentityConfiguration configuration) {
+ List<ProductionReadinessCheck.Error> errors = new ArrayList<>();
+ configuration
+ .realms()
+ .forEach(
+ (realm, config) -> {
+ if (config.awsIamServiceIdentity().isEmpty()) {
+ errors.add(
+ Error.of(
+ "AWS IAM Service identity is not configured.",
Review Comment:
Can we defer adding this check until we have end-to-end service identities
working?... just so that it's easier to reason about possible setup cases :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
