HonahX commented on code in PR #2530:
URL: https://github.com/apache/polaris/pull/2530#discussion_r2338085516
##########
runtime/distribution/build.gradle.kts:
##########
@@ -71,6 +71,17 @@ distributions {
into("bin") {
from("bin/server")
from("bin/admin")
+ from("${rootDir}/polaris")
+ }
+
+ into("bin/client") {
+ from("${rootDir}/client/python") {
+ include("**/*")
Review Comment:
Since this is binary distribution, I think it makes more sense to only
installable wheels anyway? The `polaris` script shall be able to pick up the
package after pip install, we can update the README to reflect that
> people won't be able to build this anyway with only these files without
restore the structure.
@MonkeyCanCode That's a good point. How do you feel creating a symlink
inside the `client/python` that points to the spec folder? This way we still
have single source of truth during the development but the python folder will
contain everything needed for build when copy-paste to other places.
##########
runtime/distribution/build.gradle.kts:
##########
@@ -71,6 +71,17 @@ distributions {
into("bin") {
from("bin/server")
from("bin/admin")
+ from("${rootDir}/polaris")
+ }
+
+ into("bin/client") {
+ from("${rootDir}/client/python") {
+ include("**/*")
+ }
+ }
+
+ into("regtests") {
+ from("${rootDir}/regtests/requirements.txt")
Review Comment:
It looks a little bit weird to include things from the regtests. The only
information in that file is the poetry version, may be we could refactor to
move the requirement inside `client/python`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
