MonkeyCanCode commented on code in PR #2590:
URL: https://github.com/apache/polaris/pull/2590#discussion_r2357417353
##########
build.gradle.kts:
##########
@@ -135,6 +135,13 @@ tasks.named<RatTask>("rat").configure {
excludes.add("**/*.png")
}
+tasks.register<Exec>("buildPythonClient") {
+ description = "Build the python client"
+
+ workingDir = project.projectDir
+ commandLine("make", "client-build")
Review Comment:
@HonahX this is added. Instead of hard-coded it, it is now controlled via
`FORMAT` when using the `Makefile` such as following:
```
# build both
make client-build
# build sdist
FORMAT=sdist make client-build
# build wheel
FORMAT=wheel make client-build
```
When using gradle, it is control via `python.format`:
```
# build both
./gradlew buildPythonClient
# build sdist
./gradlew buildPythonClient -Ppython.format=sdist
# build wheel
./gradlew buildPythonClient -Ppython.format=wheel
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
