fivetran-ashokborra commented on code in PR #1424:
URL: https://github.com/apache/polaris/pull/1424#discussion_r2359623372
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -349,4 +349,18 @@ public static void enforceFeatureEnabledOrThrow(
+ "it is still possible to enforce the uniqueness of table
locations within a catalog.")
.defaultValue(false)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<KmsSupportLevel>
KMS_SUPPORT_LEVEL_S3 =
+ PolarisConfiguration.<KmsSupportLevel>builder()
+ .key("ENABLE_KMS_SUPPORT_FOR_S3")
+ .catalogConfig("polaris.config.enable-kms-support-for-s3")
+ .description("If true, enables KMS support for S3 storage
integration")
+ .defaultValue(KmsSupportLevel.NONE)
Review Comment:
Do we have Java based e2e tests? I can work on adding one for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
