dimas-b commented on code in PR #2611:
URL: https://github.com/apache/polaris/pull/2611#discussion_r2361245401
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
Review Comment:
`using-polaris.md` still assume AWS when it talks about creating a catalog
:thinking:
I'd propose to break the getting started docs like this:
* Installing Dependencies
* Deploying Polaris
- Local Deployment
- Cloud Providers
- AWS
- GCP
- Azure
* Creating a Catalog
- S3
- AWS
- MinIO
- GCS
- Azure
* Using the Polaris Catalog (refer to the catalog created in the previous
section)
The MinIO and other guides may have to be re-written without references to
docker compose, just show docker instructions for MinIO, plus POLARIS CLI for
creating the catalog.
Granted it's going to be a bit more work, but I hope the end result will be
more user-friendly and will be easier to extend to new environments. WDYT?
##########
site/content/in-dev/unreleased/getting-started/alternate-conf/_index.md:
##########
@@ -0,0 +1,26 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+title: Alternate Configurations
Review Comment:
Did you mean "alternative"?
##########
site/content/in-dev/unreleased/external-idp.md:
##########
@@ -126,7 +126,7 @@ External authentication is configured via Quarkus OIDC and
Polaris-specific OIDC
### OIDC Tenant Configuration
-At least one OIDC tenant must be explicitly enabled. In Polaris, realms and
OIDC tenants are distinct concepts. An OIDC tenant represents a specific
identity provider configuration (e.g., `quarkus.oidc.idp1`). A [realm]({{% ref
"realm" %}}) is a logical partition within Polaris.
+At least one OIDC tenant (Identity Provider) must be explicitly enabled. In
Polaris, realms and OIDC tenants are distinct concepts. An OIDC tenant
represents a specific identity provider configuration (e.g.,
`quarkus.oidc.idp1`). A [realm]({{% ref "realm" %}}) is a logical partition
within Polaris.
Review Comment:
I'm not sure about this change. I believe the old text was more precise
:sweat_smile: An OIDC tenant in Quarkus is not an Identity Provider by itself,
but a "way to connect" to an Identity Provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
