dimas-b commented on code in PR #2611: URL: https://github.com/apache/polaris/pull/2611#discussion_r2363151232
########## site/content/in-dev/unreleased/getting-started/creating-a-catalog/catalog-azure.md: ########## @@ -0,0 +1,26 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +title: Creating a catalog on Azure +linkTitle: Azure +type: docs +weight: 300 +--- + +TBD Review Comment: Still TBD? ########## site/content/in-dev/unreleased/getting-started/creating-a-catalog/s3/catalog-minio.md: ########## @@ -17,9 +17,10 @@ # specific language governing permissions and limitations # under the License. # -Title: Deploying Polaris on MinIO +title: Creating a catalog on MinIO +linkTitle: MinIO type: docs -weight: 350 +weight: 200 --- In this guide we walk through setting up a simple Polaris Server with local [MinIO](https://www.min.io/) storage. Review Comment: My thinking was to just give instructions for "manual" setup in this guide (copy from the docker compose file) and may be link to the docker compose example at the end of the guide (with minimal text, just indicating that the docker compose file shows and end-to-end integration example for MinIO). WDYT? ########## site/content/in-dev/unreleased/getting-started/creating-a-catalog/s3/catalog-aws.md: ########## @@ -0,0 +1,26 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +title: Creating a catalog on AWS S3 +linkTitle: AWS +type: docs +weight: 100 +--- + +TBD Review Comment: It's more or less the same as MinIO, but you need to provide `region` and `roleArn`, but do not provide `endpoint`. ########## site/content/in-dev/unreleased/getting-started/creating-a-catalog/_index.md: ########## Review Comment: This section header is "clickable" in the left-hand pane, but the "Getting Stated" section is _not_... Could you fix that too? I guess it's related to having `render: never` in the latter... Why don't we add some text to it and render it like all the other sections? This can be done later, of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
