XN137 commented on code in PR #2533:
URL: https://github.com/apache/polaris/pull/2533#discussion_r2336466338
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##########
@@ -172,7 +126,6 @@ private static Response toResponse(BaseResult result,
Response.Status successSta
@Override
public Response createCatalog(
CreateCatalogRequest request, RealmContext realmContext, SecurityContext
securityContext) {
Review Comment:
the `realmContext` and `securityContext` params in these methods are now all
unused.
note that since this class has a `CallContext` field, we can be sure that
`realmContext` is matching the one from the injected request-scoped fields.
wondering:
should we adjust openapi `server-templates` to remove one/both from the apis
(now/in a followup)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
