olsoloviov commented on code in PR #2695:
URL: https://github.com/apache/polaris/pull/2695#discussion_r2383655288
##########
client/python/cli/command/__init__.py:
##########
@@ -186,7 +186,5 @@ def validate(self) -> None:
"""
Used to validate a command. Should always be called before `execute`.
The arg parser will catch many issues
with options, but this is used to apply additional constraints that
the arg parser can't currently handle.
- One example is that a catalog cannot be created with the `s3` storage
type without a `--role-arn` option, but
Review Comment:
Thanks for your review, @flyrain! I removed that comment since the actual
validation of role-arn for S3 storage has been removed from _catalogs_ command
in #2339, so the comment might be misleading now. We could specify AWS S3 but
there is no specific validation for AWS S3 as well. I can replace it with a
different relevant example if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
