dimas-b commented on code in PR #2706: URL: https://github.com/apache/polaris/pull/2706#discussion_r2388799872
########## site/content/in-dev/unreleased/metastores.md: ########## @@ -29,14 +29,45 @@ deprecated EclipseLink persistence backends. This implementation leverages Quarkus for datasource management and supports configuration through environment variables or JVM -D flags at startup. For more information, refer to the [Quarkus configuration reference](https://quarkus.io/guides/config-reference#env-file). +We have 2 options for configuring the persistence backend: +### 1. Relational JDBC metastore with username and password + +using environment variables: ``` POLARIS_PERSISTENCE_TYPE=relational-jdbc QUARKUS_DATASOURCE_USERNAME=<your-username> QUARKUS_DATASOURCE_PASSWORD=<your-password> QUARKUS_DATASOURCE_JDBC_URL=<jdbc-url-of-postgres> ``` +using properties file: + +``` +polaris.persistence.type=relational-jdbc +quarkus.datasource.jdbc.username=<your-username> +quarkus.datasource.jdbc.password=<your-password> +quarkus.datasource.jdbc.jdbc-url=<jdbc-url-of-postgres> +``` Review Comment: I'd prefer to avoid options like env. vs. file in main docs. All of that is essentially a config entry. There are multiple sources for the config (env., system properties, properties file) and there are differences with how you can specific config names. Also, lower case names with dots do work in the environment (e.g. in docker/k8s) but do _not_ work in `bash` (and probably other shells). I think we may need to overhaul the docs WRT user-facing config, but let's keep the existing patterns for this PR (upper case env. variables). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
