dimas-b commented on code in PR #2802:
URL: https://github.com/apache/polaris/pull/2802#discussion_r2432560906
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -178,7 +177,10 @@ private IamPolicy policyString(
Map<String, IamStatement.Builder> bucketListStatementBuilder = new
HashMap<>();
Map<String, IamStatement.Builder> bucketGetLocationStatementBuilder = new
HashMap<>();
- String arnPrefix = arnPrefixForPartition(awsPartition);
+ String arnPrefix =
arnPrefixForPartition(storageConfigurationInfo.getAwsPartition());
+ String kmsKeyArn = storageConfigurationInfo.getKmsKeyArn();
Review Comment:
It's fine either way, but if it did not work with MinIO it would be good to
mention AWS (only) in the PR description.
Also, I'm pretty sure we'll have to support KMS in MinIO at some point, so
if current changes were reusable it would be great (but not required).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
