HonahX commented on code in PR #2223:
URL: https://github.com/apache/polaris/pull/2223#discussion_r2373199259
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -2041,6 +2156,77 @@ private boolean grantPrivilegeOnTableLikeToRole(
.isSuccess();
}
+ /**
+ * Creates and persists the missing synthetic table-like entity and its
parent namespace entities
+ * for external catalogs.
+ *
+ * @param catalogEntity the external passthrough facade catalog entity.
+ * @param identifier the path of the table-like entity(including the
namespace).
+ * @param subTypes the expected subtypes of the table-like entity
+ * @param existingPathWrapper the partially resolved path currently stored
in the metastore.
+ * @return the resolved path wrapper
+ */
+ private PolarisResolvedPathWrapper createSyntheticTableLikeEntities(
+ CatalogEntity catalogEntity,
+ TableIdentifier identifier,
+ List<PolarisEntitySubType> subTypes,
+ PolarisResolvedPathWrapper existingPathWrapper) {
+
+ Namespace namespace = identifier.namespace();
+ PolarisResolvedPathWrapper resolvedNamespacePathWrapper =
+ !namespace.isEmpty()
+ ? createSyntheticNamespaceEntities(catalogEntity, namespace,
existingPathWrapper)
+ : existingPathWrapper;
+
+ if (resolvedNamespacePathWrapper == null
+ || (!namespace.isEmpty()
+ && !resolvedNamespacePathWrapper.isFullyResolvedNamespace(
+ catalogEntity.getName(), namespace))) {
+ throw new RuntimeException(
+ String.format(
+ "Failed to create synthetic namespace entities for namespace %s
in catalog %s",
+ namespace.toString(), catalogEntity.getName()));
+ }
+
+ PolarisEntity parentNamespaceEntity =
resolvedNamespacePathWrapper.getRawLeafEntity();
+
+ // TODO: Once we support GENERIC_TABLE federation, select the intended
type depending on the
+ // callsite; if it is instantiated via an Iceberg RESTCatalog factory or a
different factory
+ // for GenericCatalogs.
+ PolarisEntitySubType syntheticEntitySubType =
selectEntitySubType(subTypes);
+
+ // TODO: Instead of creating a synthetic table-like entity, rely on
external catalog mediated
+ // backfill and use the metadata location from the external catalog.
+ PolarisEntity syntheticTableEntity =
+ new IcebergTableLikeEntity.Builder(identifier, "")
+
.setId(metaStoreManager.generateNewEntityId(getCurrentPolarisContext()).getId())
+ .setCatalogId(parentNamespaceEntity.getCatalogId())
+ .setSubType(syntheticEntitySubType)
+ .setCreateTimestamp(System.currentTimeMillis())
Review Comment:
```suggestion
.setCreateTimestamp(System.currentTimeMillis())
.setParentId(parentNamespaceEntity.getId())
```
Need setParentId here too to make it resolvable later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
