singhpk234 commented on code in PR #2711:
URL: https://github.com/apache/polaris/pull/2711#discussion_r2389868245
##########
CHANGELOG.md:
##########
@@ -34,6 +34,11 @@ request adding CHANGELOG notes for breaking (!) changes and
possibly other secti
- Amazon RDS plugin enabled, this allows polaris to connect to AWS Aurora
PostgreSQL using IAM authentication.
- The EclipseLink Persistence implementation has been deprecated since 1.0.0
and will be completely removed
in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- Client requests for vended credentials will fail by default if no
credentials are available (they used to return
+ no credentials). This can happen with FILE and S3 storage that does not have
STS. Clients should normally be updated
Review Comment:
```suggestion
no credentials). This can happen with FILE and S3 compatible storage that
does not have STS. Clients should normally be updated
```
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogFileIntegrationTest.java:
##########
@@ -51,4 +53,18 @@ private static String stripTrailingSlash(String uri) {
? uri.substring(0, uri.length() - 1)
: uri;
}
+
+ @Test
+ @Override
+ @Disabled // Polaris does not provide credentials for FILE storage
+ public void testLoadCredentials() {
+ super.testLoadCredentials();
+ }
Review Comment:
should we run these test with the config to allow empty creds on ?
##########
runtime/service/src/intTest/java/org/apache/polaris/service/it/RestCatalogMinIOSpecialIT.java:
##########
@@ -301,6 +302,62 @@ public void testInternalEndpoints() throws IOException {
}
}
+ @Test
+ public void testCreateTableFailureWithCredentialVendingWithoutSts() throws
IOException {
Review Comment:
[optional] is there a way to run these test without relying on the defaults
? just incase we plan defaults this would break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
