dimas-b commented on code in PR #2852:
URL: https://github.com/apache/polaris/pull/2852#discussion_r2449556845
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java:
##########
@@ -83,15 +81,13 @@ public FileIO loadFileIO(
Optional<AccessConfig> accessConfig =
storageInfoEntity.map(
storageInfo ->
- FileIOUtil.refreshAccessConfig(
+ accessConfigProvider.getAccessConfig(
callContext,
- storageCredentialCache,
- credentialVendor,
identifier,
tableLocations,
storageActions,
- storageInfo,
Review Comment:
If `storageInfo` is no longer used, why do we still find it on line 80?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
