andrew4699 commented on code in PR #2871:
URL: https://github.com/apache/polaris/pull/2871#discussion_r2455908536
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogAdlsIntegrationTestBase.java:
##########
@@ -23,10 +23,10 @@
import org.apache.polaris.core.admin.model.StorageConfigInfo;
/** Runs PolarisRestCatalogIntegrationBase test on Azure. */
-public abstract class PolarisRestCatalogAzureIntegrationTestBase
+public abstract class PolarisRestCatalogAdlsIntegrationTestBase
extends PolarisRestCatalogIntegrationBase {
- public static final String TENANT_ID =
System.getenv("INTEGRATION_TEST_AZURE_TENANT_ID");
- public static final String BASE_LOCATION =
System.getenv("INTEGRATION_TEST_AZURE_PATH");
+ public static final String TENANT_ID =
System.getenv("INTEGRATION_TEST_ADLS_TENANT_ID");
Review Comment:
Renaming this will certainly break things that depend on it, but I haven't
been involved with the latest guidelines on changes that break internal
"interfaces", so I'd defer to what the status quo is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
