adutra commented on code in PR #2914:
URL: https://github.com/apache/polaris/pull/2914#discussion_r2472727561
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/ModelEvent.java:
##########
@@ -71,41 +102,47 @@ public interface ModelEvent extends
Converter<PolarisEvent> {
// Which resource was operated on
String getResourceIdentifier();
+ // OpenTelemetry context that was active when this event was emitted
+ @Nullable
+ String getOpenTelemetryContext();
+
// Additional parameters that were not earlier recorded
String getAdditionalProperties();
@Override
default PolarisEvent fromResultSet(ResultSet rs) throws SQLException {
var modelEvent =
ImmutableModelEvent.builder()
- .catalogId(rs.getString("catalog_id"))
- .eventId(rs.getString("event_id"))
- .requestId(rs.getString("request_id"))
- .eventType(rs.getString("event_type"))
- .timestampMs(rs.getLong("timestamp_ms"))
- .principalName(rs.getString("actor"))
Review Comment:
This change effectively fixes #2913.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
