dimas-b commented on code in PR #2887:
URL: https://github.com/apache/polaris/pull/2887#discussion_r2478903453
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -755,6 +759,10 @@ public Response reportMetrics(
ReportMetricsRequest reportMetricsRequest,
RealmContext realmContext,
SecurityContext securityContext) {
+
+ Namespace ns = decodeNamespace(namespace);
+ TableIdentifier tableIdentifier = TableIdentifier.of(ns,
RESTUtil.decodeString(table));
+ metricsReporter.reportMetric(prefix, tableIdentifier,
reportMetricsRequest.report());
Review Comment:
Sorry for cause disruption on this PR 😅 We probably need to go through
`prefixParser.prefixToCatalogName(realmContext, prefix)` here (cf.
`withCatalog(...)`)... the previous version used the catalog name as
`warehouse` in `metricsReporter.reportMetric()`, but `prefix` might be
different.
nit: it might be worth clarifying the meaning of `warehouse` in
`PolarisMetricsReporter` too. In Polaris the usual term is "catalog name".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
