flyrain commented on code in PR #2952: URL: https://github.com/apache/polaris/pull/2952#discussion_r2482320266
########## site/content/in-dev/unreleased/federation/hive-metastore-federation.md: ########## @@ -40,6 +40,35 @@ property to include `HIVE` (and any other non-REST backends you need): `runtime/server/build.gradle.kts` wires the extension in only when this flag is present, so binaries built without it will reject Hive federation requests. +## Feature configuration + +After building Polaris with Hive support, enable the necessary feature flags in your +`application.properties` file (or equivalent configuration mechanism such as environment variables or +a Kubernetes ConfigMap): + +```properties +# Allows HIVE connection type +polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST","HIVE"] + +# Allows IMPLICIT authentication +polaris.features."SUPPORTED_EXTERNAL_CATALOG_AUTHENTICATION_TYPES"=["OAUTH","IMPLICIT"] + +# Enables the federation feature itself +polaris.features."ENABLE_CATALOG_FEDERATION"=true +``` + +These flags must be set before starting the Polaris service: + +- `SUPPORTED_CATALOG_CONNECTION_TYPES` adds `HIVE` to the list of allowed catalog backends alongside + the default `ICEBERG_REST`. +- `SUPPORTED_EXTERNAL_CATALOG_AUTHENTICATION_TYPES` permits `IMPLICIT` authentication (required for + Hive federation, as described below). +- `ENABLE_CATALOG_FEDERATION` activates the federation subsystem; without it, external catalog + creation requests will be rejected. Review Comment: Minor: we could inline these description in above code comments. Something like ``` # Allows IMPLICIT authentication, needed for Hive federation polaris.features."SUPPORTED_EXTERNAL_CATALOG_AUTHENTICATION_TYPES"=["OAUTH","IMPLICIT"] ``` ########## site/content/in-dev/unreleased/federation/hive-metastore-federation.md: ########## @@ -40,6 +40,35 @@ property to include `HIVE` (and any other non-REST backends you need): `runtime/server/build.gradle.kts` wires the extension in only when this flag is present, so binaries built without it will reject Hive federation requests. +## Feature configuration + +After building Polaris with Hive support, enable the necessary feature flags in your +`application.properties` file (or equivalent configuration mechanism such as environment variables or +a Kubernetes ConfigMap): + +```properties +# Allows HIVE connection type Review Comment: Minor ```suggestion # Allows both REST and HIVE connection type ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
