MonkeyCanCode commented on code in PR #2957: URL: https://github.com/apache/polaris/pull/2957#discussion_r2486591123
########## site/docker/Dockerfile: ########## @@ -21,23 +21,14 @@ FROM ubuntu:24.04 AS hugo ENV LANGUAGE='en_US:en' -RUN apt-get update -RUN apt-get install --yes golang hugo asciidoctor npm curl -RUN apt-get clean -# http-server is used when building the static site to manually check it locally -# (via `site/bin/create-static-site.sh --local` at http://localhost:8080/) -RUN npm install --global http-server - -# these dependencies are needed to build the static site -#RUN npm install --global autoprefixer postcss postcss-cli http-server - -RUN mkdir /polaris -RUN mkdir /polaris/site -RUN mkdir /polaris/site/resources +RUN apt-get update && \ + apt-get install -y --no-install-recommends golang hugo asciidoctor npm curl git && \ + npm install --global http-server && \ + rm -rf /var/lib/apt/lists/* && \ Review Comment: Actually I was thinking about the same as rm is related to apt cache cleanup but npm is part of setup before cleanup, thus above layout. But I think it may be better for instructions with apt grouping then npm at the end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
