dimas-b commented on code in PR #2883:
URL: https://github.com/apache/polaris/pull/2883#discussion_r2487531782
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/ScopedCredentialsResult.java:
##########
@@ -37,20 +37,20 @@ public class ScopedCredentialsResult extends BaseResult {
public ScopedCredentialsResult(
@Nonnull ReturnStatus errorCode, @Nullable String extraInformation) {
super(errorCode, extraInformation);
- this.accessConfig = null;
+ this.storageAccessConfig = null;
}
/**
* Constructor for success
*
- * @param accessConfig credentials
+ * @param storageAccessConfig credentials generated by a successful
getSubscopedCredsForEntity()
Review Comment:
@CodingBangboo @HonahX : I know this is a minor point, but I'd prefer to
avoid false requirements in javadoc... WDYT about this one?
To be clear: I propose to remove this javadoc line completely. I believe the
java doc on the parameter type is sufficient in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
