snazy commented on code in PR #2911:
URL: https://github.com/apache/polaris/pull/2911#discussion_r2487585004
##########
build-logic/src/main/kotlin/publishing/configurePom.kt:
##########
@@ -85,7 +86,14 @@ internal fun configurePom(project: Project,
mavenPublication: MavenPublication,
licenses {
license {
name.set("Apache-2.0") // SPDX identifier
- url.set(asfProject.licenseUrl)
+ url.set(gitInfo.rawGithubLink("LICENSE"))
+ comments.set(
+ """
+ NOTICE: ${gitInfo.rawGithubLink("NOTICE")}
+ DISCLAIMER: ${gitInfo.rawGithubLink("DISCLAIMER")}
Review Comment:
The link would be correct (e.g.
`https://raw.githubusercontent.com/apache/polaris/$rawLinkRef/$file` translates
to https://raw.githubusercontent.com/apache/polaris/HEAD/LICENSE) in case it's
not a release.
I don't see a better alternative than `HEAD` here for non-release builds, as
the Git commit SHA could be from "anywhere".
However, the referenced files are probably not the right ones for the root
pom.
Hm - maybe let's drop this PR. I'll leave it open for a bit, but it looks
like it's incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
