MonkeyCanCode opened a new pull request, #3016: URL: https://github.com/apache/polaris/pull/3016
This PR cleans up how OpenAPI-generated model imports for policies are handled. Previously, we used a runtime patch `_patch_generated_models()` in `polaris_cli.py` to work around missing policies imports. That logic has now been moved to the client generation process in `generate_clients.py`. A new helper function, `fix_catalog_models_init()`, was added to regenerate the `apache_polaris.sdk.catalog.models.__init__.py` file so it correctly imports all model classes. This makes the generated client more reliable and removes the need for any runtime patching (or more monkey patching later as we have more classes added which is not part of Iceberg catalog spec). ## Checklist - [x] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [x] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [x] ๐ก Added comments for complex logic - [x] ๐งพ Updated `CHANGELOG.md` (if needed) - [x] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
