XN137 commented on code in PR #3024:
URL: https://github.com/apache/polaris/pull/3024#discussion_r2511793069
##########
runtime/service/src/main/java/org/apache/polaris/service/auth/internal/broker/TokenBrokerFactory.java:
##########
@@ -18,11 +18,17 @@
*/
package org.apache.polaris.service.auth.internal.broker;
-import java.util.function.Function;
+import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.context.RealmContext;
+import org.apache.polaris.core.persistence.PolarisMetaStoreManager;
/**
* Factory that creates a {@link TokenBroker} for generating and parsing. The
{@link TokenBroker} is
* created based on the realm context.
*/
-public interface TokenBrokerFactory extends Function<RealmContext,
TokenBroker> {}
+public interface TokenBrokerFactory {
+ TokenBroker create(
+ RealmContext realmContext,
+ PolarisMetaStoreManager metaStoreManager,
+ PolarisCallContext polarisCallContext);
Review Comment:
you are right that it was redundant, added a commit to address it.
long term i think we should get to a point where `RealmConfig` is produced
independently of `CallContext`, so because of that i was providing it
separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
