gh-yzou commented on code in PR #3000:
URL: https://github.com/apache/polaris/pull/3000#discussion_r2512218855
##########
site/content/in-dev/unreleased/polaris-spark-client.md:
##########
@@ -22,17 +22,17 @@ type: docs
weight: 650
---
-Apache Polaris now provides Catalog support for Generic Tables (non-Iceberg
tables), please check out
-the [Polaris Catalog OpenAPI Spec]({{% ref
"polaris-api-specs/polaris-catalog-api.md" %}}) for Generic Table API specs.
+Polaris provides a Spark client to manage non-Iceberg tables through [Generic
Tables]({{% ref "generic-table.md" %}}).
-Along with the Generic Table Catalog support, Polaris is also releasing a
Spark client, which helps to
-provide an end-to-end solution for Apache Spark to manage Delta tables using
Polaris.
+{{< alert note >}}
+The Spark client can manage Iceberg tables and non-Iceberg tables.
-Note the Polaris Spark client is able to handle both Iceberg and Delta tables,
not just Delta.
+Users who only use Iceberg tables can use Spark without this client.
Review Comment:
Oh, sorry for the confusion, i was just suggesting to rephrase it like above
to make it more accurate. Not really mean we should remove this description.
##########
site/content/in-dev/unreleased/generic-table.md:
##########
@@ -157,13 +158,10 @@ curl -X DELETE
http://localhost:8181/api/catalog/polaris/v1/delta_catalog/namesp
For the complete and up-to-date API specification, see the [Catalog API
Spec](https://editor-next.swagger.io/?url=https://raw.githubusercontent.com/apache/polaris/refs/heads/main/spec/generated/bundled-polaris-catalog-service.yaml).
-## Limitations
+## Known Limitations
-Current limitations of Generic Table support:
-1) Limited spec information. Currently, there is no spec for information like
Schema, Partition etc.
-2) No commit coordination or update capability provided at the catalog service
level.
-
-Therefore, the catalog itself is unaware of anything about the underlying
table except some of the loosely defined metadata.
-It is the responsibility of the engine (and plugins used by the engine) to
determine exactly how loading or committing data
Review Comment:
looks good to me!
##########
site/content/in-dev/unreleased/polaris-spark-client.md:
##########
@@ -119,11 +119,16 @@ If you would like to use a version of the Spark client
that is currently not yet
build a Spark client jar locally from source. Please check out the Polaris
repo and refer to the Spark plugin
[README](https://github.com/apache/polaris/blob/main/plugins/spark/README.md)
for detailed instructions.
-## Limitations
-The Polaris Spark client has the following functionality limitations:
-1) Create table as select (CTAS) is not supported for Delta tables. As a
result, the `saveAsTable` method of `Dataframe`
+## Known Limitations
Review Comment:
may be let's stay consistent on the titles, "Known Limitations" -> "Current
Limitations"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
