sungwy commented on code in PR #3031: URL: https://github.com/apache/polaris/pull/3031#discussion_r2520822771
########## extensions/auth/opa/impl/src/main/java/org/apache/polaris/extension/auth/opa/model/Resource.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.extension.auth.opa.model; + +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.databind.annotation.JsonDeserialize; +import com.fasterxml.jackson.databind.annotation.JsonSerialize; +import java.util.List; +import org.apache.polaris.immutables.PolarisImmutable; + +/** + * Represents the resource(s) being accessed in an authorization request. + * + * <p>Contains primary target entities and optional secondary entities. + */ +@PolarisImmutable +@JsonSerialize(as = ImmutableResource.class) +@JsonDeserialize(as = ImmutableResource.class) +public interface Resource { + /** The primary target entities being accessed. */ + @JsonProperty("targets") + List<ResourceEntity> targets(); + + /** Secondary entities involved in the operation (e.g., source table in RENAME). */ + @JsonProperty("secondaries") + List<ResourceEntity> secondaries(); Review Comment: Thanks @snazy - that's a good suggestion. Now that I look at it, `targets` is also Nullable according to the `authorizeOrThrow` Authorizer interface method. I'll adopt a similar suggestion there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
