tmater opened a new pull request, #3095: URL: https://github.com/apache/polaris/pull/3095
## Summary Disables 5 view catalog tests for cloud storage providers (S3, ADLS, GCS) that use `@TempDir`. The `ViewCatalogTests` base class uses `Paths.get()` with the temp directory, which doesn't support cloud storage paths. Follow-up to https://github.com/apache/polaris/pull/2871. ## Background These tests inherit from Iceberg's `ViewCatalogTests`, which passes a `@TempDir` path to `Paths.get()`. Since `Paths.get()` only accepts local filesystem paths, it cannot handle cloud storage URIs. For example, when `@TempDir` provides `/tmp/junit123`, `Paths.get()` converts it to a URI like `file:///tmp/junit123`. But for cloud storage base paths like `s3://bucket/path`, it would incorrectly create `s3:/bucket/path` (single slash) instead of the valid `s3://bucket/path` format. These tests are disabled to prevent false positives - they would pass by testing against local filesystem instead of actually validating cloud storage behavior. ## Changes **Base test classes** - Added `@Disabled` overrides for 5 tests: - `PolarisRestCatalogViewAdlsIntegrationTestBase.java` - `PolarisRestCatalogViewGcsIntegrationTestBase.java` - `PolarisRestCatalogViewS3IntegrationTestBase.java` **Concrete test classes** - Removed reflection workaround: - `RestCatalogViewAdlsIT.java` - `RestCatalogViewGcsIT.java` - `RestCatalogViewS3IT.java` ## Testing Run cloud tests: `./gradlew cloudTest` ## Future Work Will follow up with changes to Iceberg's `ViewCatalogTests` to avoid using `Paths.get()` with `@TempDir`. Once that's done, these tests can be re-enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
